From 46aa50205e884afe85e0c5ff04f3d8351e68e1a5 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Thu, 8 Jun 2017 13:13:48 +0000 Subject: [PATCH] Skip a regex if we don't need the captured result At least in theory this is more efficient but the gains don't seem impressive enough to be clearly measurable with real world log files. At least it looks faster now ... --- tools/privoxy-log-parser.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/privoxy-log-parser.pl b/tools/privoxy-log-parser.pl index a5b5b618..e8503f11 100755 --- a/tools/privoxy-log-parser.pl +++ b/tools/privoxy-log-parser.pl @@ -8,7 +8,7 @@ # # https://www.fabiankeil.de/sourcecode/privoxy-log-parser/ # -# $Id: privoxy-log-parser.pl,v 1.169 2017/03/03 17:43:11 fabiankeil Exp $ +# $Id: privoxy-log-parser.pl,v 1.170 2017/03/03 17:43:35 fabiankeil Exp $ # # TODO: # - LOG_LEVEL_CGI, LOG_LEVEL_ERROR, LOG_LEVEL_WRITE content highlighting @@ -2100,8 +2100,8 @@ sub gather_loglevel_header_stats ($$) { } $stats{'http-version'}{$4}++; - } elsif ($c =~ m/^scan: Host: ([^\s]+)/ and - $cli_options{'host-statistics-threshold'} != 0) { + } elsif ($cli_options{'host-statistics-threshold'} != 0 and + $c =~ m/^scan: Host: ([^\s]+)/) { # scan: Host: p.p $stats{'hosts'}{$1}++; -- 2.39.2