From: Fabian Keil <fk@fabiankeil.de>
Date: Sat, 27 Oct 2007 13:12:13 +0000 (+0000)
Subject: Finish 1.49 and check write access before
X-Git-Tag: v_3_0_7~114
X-Git-Url: http://www.privoxy.org/gitweb/%40user-manual%40%40actions-help-prefix%40HANDLE-AS-EMPTY-DOCUMENT?a=commitdiff_plain;h=377bb95c67b8ad7a705691695297fd08e43901b6;p=privoxy.git

Finish 1.49 and check write access before
showing edit buttons on show-url-info page.
---

diff --git a/cgisimple.c b/cgisimple.c
index eb28bdad..35284a08 100644
--- a/cgisimple.c
+++ b/cgisimple.c
@@ -1,4 +1,4 @@
-const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.58 2007/07/21 12:19:50 fabiankeil Exp $";
+const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.59 2007/10/19 16:42:36 fabiankeil Exp $";
 /*********************************************************************
  *
  * File        :  $Source: /cvsroot/ijbswa/current/cgisimple.c,v $
@@ -36,6 +36,10 @@ const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.58 2007/07/21 12:19:50 fabian
  *
  * Revisions   :
  *    $Log: cgisimple.c,v $
+ *    Revision 1.59  2007/10/19 16:42:36  fabiankeil
+ *    Plug memory leak I introduced five months ago.
+ *    Yay Valgrind and Privoxy-Regression-Test.
+ *
  *    Revision 1.58  2007/07/21 12:19:50  fabiankeil
  *    If show-url-info is called with an URL that Privoxy
  *    would reject as invalid, don't show unresolved forwarding
@@ -1539,10 +1543,22 @@ jb_err cgi_show_url_info(struct client_state *csp,
                string_append(&matches, buf);
                string_append(&matches, "View</a>");
 #ifdef FEATURE_CGI_EDIT_ACTIONS
-               snprintf(buf, sizeof(buf), " <a class=\"cmd\" href=\"/edit-actions-list?f=%d\">", i);
-               string_append(&matches, buf);
-               string_append(&matches, "Edit</a>");
-#endif
+#ifdef HAVE_ACCESS
+               if (access(csp->config->actions_file[i], W_OK) == 0)
+               {
+#endif /* def HAVE_ACCESS */
+                  snprintf(buf, sizeof(buf), " <a class=\"cmd\" href=\"/edit-actions-list?f=%d\">", i);
+                  string_append(&matches, buf);
+                  string_append(&matches, "Edit</a>");
+#ifdef HAVE_ACCESS
+               }
+               else
+               {
+                  string_append(&matches, " <strong>No write access.</strong>");
+               }
+#endif /* def HAVE_ACCESS */
+#endif /* FEATURE_CGI_EDIT_ACTIONS */
+
                string_append(&matches, "</th></tr>\n");
 
                hits = 0;