Fabian Keil [Sat, 24 Jan 2015 16:42:23 +0000 (16:42 +0000)]
Add Matthew Daley as contributor
Fabian Keil [Sat, 24 Jan 2015 16:42:13 +0000 (16:42 +0000)]
Emphasize that Privoxy is serious business
Fabian Keil [Sat, 24 Jan 2015 16:41:51 +0000 (16:41 +0000)]
Add parse_time_header(), a wrapper around parse_header_time()
... which skips the header name for the callers which means
they can't get it wrong. Previously two callers did. This could
result in 'invalid read of size X' issues in case of value-less
headers.
On the systems I tested, X was always 1 and nobody but valgrind
cared, but with different malloc() implementations Privoxy might
be less lucky and segfault.
Partially discovered with afl-fuzz.
Fabian Keil [Sat, 24 Jan 2015 16:41:20 +0000 (16:41 +0000)]
chunked_body_is_complete(): Check input more carefully
Previously a nul-chunk without mandatory trailing "\r\n" would
not be rejected as invalid. When compiled with assertions enabled,
this would cause Privoxy to abort().
Reported by Matthew Daley.
Fabian Keil [Sat, 24 Jan 2015 16:40:59 +0000 (16:40 +0000)]
pcrs_compile_replacement(): Fix multiple segfaults and memory leaks
... and report errors more reliably. Previously some invalid
pcrs commands were silently accepted but didn't work as expected.
Partially discovered with afl-fuzz.
Fabian Keil [Sat, 24 Jan 2015 16:40:47 +0000 (16:40 +0000)]
Add ElectroBSD to the list of BSDs Privoxy is known to run on
Fabian Keil [Sat, 24 Jan 2015 16:40:37 +0000 (16:40 +0000)]
Fix comment typo
Fabian Keil [Sat, 24 Jan 2015 16:40:21 +0000 (16:40 +0000)]
Properly explain why the pcrs job couldn't be compiled
Fabian Keil [Sat, 24 Jan 2015 16:40:07 +0000 (16:40 +0000)]
Grammar fixes for the dok-tidy description
Fabian Keil [Sat, 24 Jan 2015 16:39:53 +0000 (16:39 +0000)]
Add a web-user-manual target that uses rsync
Fabian Keil [Fri, 19 Dec 2014 12:36:06 +0000 (12:36 +0000)]
Remove #84 as it's a duplicate of #51
Rephrase #51 to make it more obvious.
Fabian Keil [Fri, 19 Dec 2014 12:35:30 +0000 (12:35 +0000)]
Fix spelling in #126
Fabian Keil [Fri, 19 Dec 2014 12:32:15 +0000 (12:32 +0000)]
Regenerate documentation
Fabian Keil [Fri, 19 Dec 2014 12:31:46 +0000 (12:31 +0000)]
Add the Paypal address
Fabian Keil [Fri, 19 Dec 2014 12:31:28 +0000 (12:31 +0000)]
Remove CVS $Log
Fabian Keil [Fri, 19 Dec 2014 12:31:10 +0000 (12:31 +0000)]
Unblock .amnesty.de/
Fabian Keil [Fri, 19 Dec 2014 12:30:53 +0000 (12:30 +0000)]
Ditch previously missed 'Bookmarklets' section in the templates
Fabian Keil [Fri, 19 Dec 2014 12:30:38 +0000 (12:30 +0000)]
Deemphasize the existence of the SF support trackers which have been broken for months
Fabian Keil [Fri, 19 Dec 2014 12:29:53 +0000 (12:29 +0000)]
Stop pretending that default.action updates are made available on their own
Fabian Keil [Fri, 19 Dec 2014 12:29:39 +0000 (12:29 +0000)]
Remove the 'Request New Features' section
The tracker has been broken for months and the TODO list is long
enough anyway.
Fabian Keil [Fri, 19 Dec 2014 12:29:20 +0000 (12:29 +0000)]
Add +limit-cookie-lifetime{} to the list of avilable actions
Fabian Keil [Fri, 19 Dec 2014 12:28:10 +0000 (12:28 +0000)]
Fix comment typos
Fabian Keil [Fri, 28 Nov 2014 14:26:35 +0000 (14:26 +0000)]
Explicitly mention that Tor's port may deviate from the default
... when using a bundle.
Reported by Andrew on ijbswa-users@.
Fabian Keil [Fri, 28 Nov 2014 14:13:22 +0000 (14:13 +0000)]
Stop blocking .sify.com/
It's not actually a pure tracking site (anymore?).
Reported by Andrew on ijbswa-users@.
Fabian Keil [Fri, 28 Nov 2014 14:13:02 +0000 (14:13 +0000)]
Bump version to 3.0.23 UNRELEASED
Fabian Keil [Thu, 20 Nov 2014 15:30:38 +0000 (15:30 +0000)]
Add Kai Raven to the list of contributors
Fabian Keil [Thu, 20 Nov 2014 15:30:14 +0000 (15:30 +0000)]
Update the announcement for 3.0.22
Fabian Keil [Thu, 20 Nov 2014 15:29:57 +0000 (15:29 +0000)]
Add a bunch of missing test levels
Prevents test failures when the action file editor has
been disabled or isn't available.
Fabian Keil [Thu, 20 Nov 2014 15:29:36 +0000 (15:29 +0000)]
Add FEATURE_CGI_EDIT_ACTIONS dependency for test level 12
Fabian Keil [Tue, 18 Nov 2014 14:22:36 +0000 (14:22 +0000)]
Rebuild docs
Fabian Keil [Tue, 18 Nov 2014 14:22:17 +0000 (14:22 +0000)]
Note that --disable-force is known to be broken
Fabian Keil [Tue, 18 Nov 2014 14:21:56 +0000 (14:21 +0000)]
Skip test level 13 unless the keep-alive-timeout is above 20
The tests are expected to fail with lower values, for example
the 5 seconds specified in the default config file.
Reported by Lee.
Fabian Keil [Sun, 16 Nov 2014 18:43:48 +0000 (18:43 +0000)]
Make the FORCE_PREFIX define always visible
Fixes a compile error when configured with --disable-force in
which case the define is still required for the show-status page.
Reported by Kai Raven.
Fabian Keil [Fri, 14 Nov 2014 13:50:51 +0000 (13:50 +0000)]
Fix a ChangeLog entry
Fabian Keil [Fri, 14 Nov 2014 12:59:11 +0000 (12:59 +0000)]
Revert r1.54 "Add range-related tests for external-filter{}"
When configured with the defaults, Privoxy does not accept
the external-filter{} action. Privoxy should probably be
changed to silently ignore the action, but this will have
to wait until the next release.
Fabian Keil [Fri, 14 Nov 2014 11:32:27 +0000 (11:32 +0000)]
Rebuild HTML docs
Fabian Keil [Fri, 14 Nov 2014 11:32:05 +0000 (11:32 +0000)]
Rebuild text docs
Fabian Keil [Fri, 14 Nov 2014 11:31:53 +0000 (11:31 +0000)]
Rebuild config file for 3.0.22 stable
Fabian Keil [Fri, 14 Nov 2014 11:31:41 +0000 (11:31 +0000)]
Update SGML ChangeLog
Fabian Keil [Fri, 14 Nov 2014 11:31:24 +0000 (11:31 +0000)]
Prevent leading and trailing whitespace in quotes
Fabian Keil [Fri, 14 Nov 2014 11:31:11 +0000 (11:31 +0000)]
ChangeLog cosmetic
Fabian Keil [Fri, 14 Nov 2014 11:30:59 +0000 (11:30 +0000)]
Declare 3.0.22 'stable'
Fabian Keil [Fri, 14 Nov 2014 10:40:50 +0000 (10:40 +0000)]
ChangeLog cosmetic
Fabian Keil [Fri, 14 Nov 2014 10:40:40 +0000 (10:40 +0000)]
Update ChangeLog to reflect recent changes
Fabian Keil [Fri, 14 Nov 2014 10:40:24 +0000 (10:40 +0000)]
Fix memory leak in rfc2553_connect_to()
CID 66382.
Fabian Keil [Fri, 14 Nov 2014 10:40:10 +0000 (10:40 +0000)]
pcrs_execute(): Consistently set *result to NULL in case of errors
Should make use-after-free in the caller less likely.
CID 66391, CID 66376.
Fabian Keil [Fri, 14 Nov 2014 10:39:49 +0000 (10:39 +0000)]
unmap(): Prevent use-after-free if the map only consists of one item
CID 66394.
Fabian Keil [Wed, 12 Nov 2014 12:00:41 +0000 (12:00 +0000)]
Make sure csp flags have unique values
Previously CSP_FLAG_CRUNCHED and CSP_FLAG_CLIENT_CONNECTION_HEADER_SET
shared the same bit which obviously wasn't intentional.
The only negative effect was that Privoxy potentially reused less
connections than it could have, which explains why the problem hasn't
been noticed for seven years and was only found by manual code
inspection.
Fabian Keil [Wed, 12 Nov 2014 12:00:10 +0000 (12:00 +0000)]
Link to the 'Would you like to donate?' FAQ
... instead of repeating parts of it while leaving out the rest.
Fabian Keil [Wed, 12 Nov 2014 11:59:47 +0000 (11:59 +0000)]
Let server_keep_alive() always remove the Keep-Alive header
Not forwarding the header to the client is a MUST and
non-compliance has no advantage here.
Fixes Co-Advisor test case rfc2616/hopHdr-Keep-Alive-toClt.
Fabian Keil [Tue, 11 Nov 2014 12:19:52 +0000 (12:19 +0000)]
Update URL of Polipo's website
Fabian Keil [Tue, 11 Nov 2014 12:19:38 +0000 (12:19 +0000)]
Disable banners-by-size for kggp.de/
Fabian Keil [Mon, 3 Nov 2014 14:41:12 +0000 (14:41 +0000)]
Preserve negative HTTP status numbers
While they are technically invalid, "supporting" them doesn't
hurt and this gets the recently added curl test 1430 "working".
Fabian Keil [Mon, 3 Nov 2014 14:40:53 +0000 (14:40 +0000)]
Add two consenting donors to the list of contributors
Fabian Keil [Mon, 3 Nov 2014 14:40:25 +0000 (14:40 +0000)]
Add changes for 3.0.22 stable
Fabian Keil [Mon, 3 Nov 2014 14:39:37 +0000 (14:39 +0000)]
Add a couple of contributors
Fabian Keil [Tue, 21 Oct 2014 15:31:49 +0000 (15:31 +0000)]
Regenerate docs
Fabian Keil [Tue, 21 Oct 2014 15:31:32 +0000 (15:31 +0000)]
Add #138: Bring back the scripts to provide actions file feedback
Fabian Keil [Tue, 21 Oct 2014 15:31:16 +0000 (15:31 +0000)]
Bump copyright
Fabian Keil [Tue, 21 Oct 2014 15:31:05 +0000 (15:31 +0000)]
Fix web-actions target
Fabian Keil [Tue, 21 Oct 2014 15:30:52 +0000 (15:30 +0000)]
Garbage-collect bookmarklets section
Most of the bookmarklets can't possible work due to not using a
trusted referer header and the rest of them can be replaced with
common bookmarks.
Fabian Keil [Tue, 21 Oct 2014 15:30:27 +0000 (15:30 +0000)]
Formally declare the scripts in doc/webserver/actions/ out of action
They haven't worked in years and the docs no longer reference them.
Fabian Keil [Tue, 21 Oct 2014 15:30:06 +0000 (15:30 +0000)]
Add a web-faq target that only updates the FAQ on the webserver
Fabian Keil [Tue, 21 Oct 2014 15:29:46 +0000 (15:29 +0000)]
Remove already-commented-out non-portable DOSFILTER alternatives
Fabian Keil [Tue, 21 Oct 2014 15:29:34 +0000 (15:29 +0000)]
Remove the obsolete targets dok-put and dok-get
Fabian Keil [Tue, 21 Oct 2014 15:29:20 +0000 (15:29 +0000)]
Add a sf-shell target
Fabian Keil [Tue, 21 Oct 2014 12:05:55 +0000 (12:05 +0000)]
Regenerate FAQ
Fabian Keil [Tue, 21 Oct 2014 12:05:12 +0000 (12:05 +0000)]
Mention more stuff donations may be used for
Fabian Keil [Tue, 21 Oct 2014 12:02:16 +0000 (12:02 +0000)]
Bump FAQ copyright
Fabian Keil [Tue, 21 Oct 2014 12:01:59 +0000 (12:01 +0000)]
Fix comment typos in free_map()'s description
Fabian Keil [Sat, 18 Oct 2014 11:32:07 +0000 (11:32 +0000)]
Remove #138. Coverity scan results are analyzed
Fabian Keil [Sat, 18 Oct 2014 11:31:52 +0000 (11:31 +0000)]
Let new_map() exit if the new map can't be allocated
This is not expected to happen in the real world
and it makes life easier for the callers.
Fabian Keil [Sat, 18 Oct 2014 11:31:25 +0000 (11:31 +0000)]
Add missing return check in dispatch_known_cgi()
CID 66354.
Fabian Keil [Sat, 18 Oct 2014 11:31:12 +0000 (11:31 +0000)]
receive_client_request(): Don't ignore list_append_list_unique()'s return value
CID 66360.
Fabian Keil [Sat, 18 Oct 2014 11:30:56 +0000 (11:30 +0000)]
Fix error handling in server_content_type()
CID 66369.
Fabian Keil [Sat, 18 Oct 2014 11:30:40 +0000 (11:30 +0000)]
jb_err_to_string(): Only check for internal errors once
Silences a Coverity complaint about unreachable code.
CID 66387.
Fabian Keil [Sat, 18 Oct 2014 11:30:24 +0000 (11:30 +0000)]
The filter file array can't be NULL so don't bother checking
The intention was checking whether or not filters are available,
but that's a premature optimization for an unlikely scenario,
so the bogus checks can be dropped without replacement.
CID 66389, CID 66385, CID 66375.
Fabian Keil [Sat, 18 Oct 2014 11:30:04 +0000 (11:30 +0000)]
server_content_encoding(): Check for enabled content filters properly
Previously external filters and gif deanimation weren't considered.
CID 66374.
Fabian Keil [Sat, 18 Oct 2014 11:29:48 +0000 (11:29 +0000)]
Fix error handling in edit_write_file()
CID 66359.
Fabian Keil [Sat, 18 Oct 2014 11:29:22 +0000 (11:29 +0000)]
Fix error handling in edit_read_file()
CID 66359.
Fabian Keil [Sat, 18 Oct 2014 11:29:06 +0000 (11:29 +0000)]
edit_read_file(): Remove bogus NULL check and use strdup_or_die() instead
CID 66372.
Fabian Keil [Sat, 18 Oct 2014 11:28:49 +0000 (11:28 +0000)]
Fix memory leak in cgi_show_file()
CID 66362.
Fabian Keil [Sat, 18 Oct 2014 11:28:36 +0000 (11:28 +0000)]
Use strdup_or_die() if the duplicated string is tiny
Fixes a theoretical memory leak in trust_url() reported by Coverity.
CID 66364.
Fabian Keil [Sat, 18 Oct 2014 11:28:05 +0000 (11:28 +0000)]
bind_port(): Fix file descriptor leak in error path
CID 66368.
Fabian Keil [Sat, 18 Oct 2014 11:27:43 +0000 (11:27 +0000)]
In bind_port(), check if the socket is valid before marking it CLOSEEXEC
Fabian Keil [Sat, 18 Oct 2014 11:27:28 +0000 (11:27 +0000)]
Fix memory leaks in load_config()
CID 66370.
Fabian Keil [Sat, 18 Oct 2014 11:27:04 +0000 (11:27 +0000)]
Fix memory leak in pcrs_compile_dynamic_command()
CID 66373.
Fabian Keil [Sat, 18 Oct 2014 11:26:48 +0000 (11:26 +0000)]
Fix a theoretical memory leak in get_last_url()
CID 66378.
Fabian Keil [Sat, 18 Oct 2014 11:26:31 +0000 (11:26 +0000)]
load_file(): Treat fread() failures like other non-fatal file errors
... and check for underreads properly.
Previously Privoxy was supposedly serving the file partially
if it was edited in place, but actually would have served an
error message and leaked memory. Now it just serves the error
message (if it's run in a fantasy world were this actually
happens).
CID 66380, CID 66362, CID 66357.
Fabian Keil [Sat, 18 Oct 2014 11:26:18 +0000 (11:26 +0000)]
Fix a memory leak in execute_content_filters() if there's more than one job
Also don't crash if a job that isn't the last one fails.
CID 66381.
Fabian Keil [Sat, 18 Oct 2014 11:25:57 +0000 (11:25 +0000)]
execute_external_filter(): Fix file descriptor leak in error path
CID 66384.
Fabian Keil [Sat, 18 Oct 2014 11:25:42 +0000 (11:25 +0000)]
Fix theoretical memory leaks in edit_parse_actions_file()
CID 66388.
Fabian Keil [Sat, 18 Oct 2014 11:25:24 +0000 (11:25 +0000)]
Fix a comment typo
Fabian Keil [Sat, 18 Oct 2014 11:25:13 +0000 (11:25 +0000)]
Fix a theoretical memory leak in cgi_show_url_info()
In the real world map_block_killer() is unlikely to run out of memory.
CID 66392.
Fabian Keil [Sat, 18 Oct 2014 11:24:53 +0000 (11:24 +0000)]
accept_connection(): Adjust loop condition to silence a ressource leak warning
This is a nop because fd 0 is guaranteed to be in use and
thus can't be returned by accept() anyway.
CID 66393.
Fabian Keil [Sat, 18 Oct 2014 11:24:34 +0000 (11:24 +0000)]
server_http(): Make the HTTP reason phrase optional again
There are still servers around that that don't set one
and Privoxy doesn't really need it anyway.
Fabian Keil [Fri, 17 Oct 2014 14:45:41 +0000 (14:45 +0000)]
Bump copyright
Fabian Keil [Fri, 17 Oct 2014 14:45:29 +0000 (14:45 +0000)]
Add range-related tests for external-filter{}
Fabian Keil [Fri, 17 Oct 2014 14:45:10 +0000 (14:45 +0000)]
Prevent img-reorder from messing up img tags with empty src attributes
Fixes #880 reported by Duncan.
Fabian Keil [Thu, 16 Oct 2014 11:55:45 +0000 (11:55 +0000)]
Add #138: Analyse Coverity scan results
Remove #55 which is done.