privoxy.git
6 months agolog_error(): Add missing space and new line in fatal error message
Fabian Keil [Mon, 3 Jun 2024 14:57:34 +0000 (16:57 +0200)]
log_error(): Add missing space and new line in fatal error message

7 months agoRemove silver sponsor scrubtheweb.com
Fabian Keil [Wed, 22 May 2024 12:36:25 +0000 (14:36 +0200)]
Remove silver sponsor scrubtheweb.com

7 months agoRemove bronze sponsor vpnxpert.com
Fabian Keil [Wed, 22 May 2024 12:32:36 +0000 (14:32 +0200)]
Remove bronze sponsor vpnxpert.com

7 months agoRemove bronze sponsor moneybanker.fr
Fabian Keil [Wed, 22 May 2024 12:31:32 +0000 (14:31 +0200)]
Remove bronze sponsor moneybanker.fr

7 months agoRemove bronze sponsor www.betrugstest.com
Fabian Keil [Wed, 22 May 2024 12:30:58 +0000 (14:30 +0200)]
Remove bronze sponsor www.betrugstest.com

7 months agoBump copyright
Fabian Keil [Fri, 3 May 2024 13:50:01 +0000 (15:50 +0200)]
Bump copyright

7 months agoAdd www.proxidize.com as Bronze level sponsor
Fabian Keil [Fri, 3 May 2024 13:40:19 +0000 (15:40 +0200)]
Add www.proxidize.com as Bronze level sponsor

8 months agowolfSSL: Use LIBWOLFSSL_VERSION_HEX to decide whether or not to use WOLFSSL_X509_V_OK
Fabian Keil [Mon, 1 Apr 2024 15:19:06 +0000 (17:19 +0200)]
wolfSSL: Use LIBWOLFSSL_VERSION_HEX to decide whether or not to use WOLFSSL_X509_V_OK

As Roland pointed out, in older wolfSSL releases X509_V_OK
is an enum so the previous commit 838bc3c0e did not work
as expected there.

8 months agowolfSSL: Unconditionally increment shutdown_attempts
Fabian Keil [Mon, 1 Apr 2024 14:41:27 +0000 (16:41 +0200)]
wolfSSL: Unconditionally increment shutdown_attempts

Previously the succeeding attempt wasn't counted.

8 months agowolfSSL: Bump MAX_SHUTDOWN_ATTEMPTS to 5 as an experiment
Fabian Keil [Mon, 1 Apr 2024 11:46:39 +0000 (13:46 +0200)]
wolfSSL: Bump MAX_SHUTDOWN_ATTEMPTS to 5 as an experiment

8 months agoprivoxy-log-parser: Highlight 'Not shutting down client connection on socket 8. The...
Fabian Keil [Mon, 1 Apr 2024 11:31:20 +0000 (13:31 +0200)]
privoxy-log-parser: Highlight 'Not shutting down client connection on socket 8. The socket is no longer alive.'

8 months agoBump copyright
Fabian Keil [Sun, 31 Mar 2024 15:50:18 +0000 (17:50 +0200)]
Bump copyright

8 months agowolfSSL: Use X509_V_OK if it's available
Fabian Keil [Sun, 31 Mar 2024 15:16:46 +0000 (17:16 +0200)]
wolfSSL: Use X509_V_OK if it's available

Older wolfSSL releases don't have WOLFSSL_X509_V_OK yet.

Reported by Roland [0].

[0]: <https://lists.privoxy.org/pipermail/privoxy-devel/2024-March/000759.html>

8 months agowolfSSL: Use variable type wc_Md5 instead of md5
Fabian Keil [Sun, 31 Mar 2024 15:04:43 +0000 (17:04 +0200)]
wolfSSL: Use variable type wc_Md5 instead of md5

As Roland reported [0] the latter may not be available.

[0] <https://lists.privoxy.org/pipermail/privoxy-devel/2024-March/000759.html>

8 months agowolfSSL: Use variable type WC_RNG instead of RNG
Fabian Keil [Sun, 31 Mar 2024 15:01:36 +0000 (17:01 +0200)]
wolfSSL: Use variable type WC_RNG instead of RNG

As Roland reported [0] the latter may not be available.

[0] <https://lists.privoxy.org/pipermail/privoxy-devel/2024-March/000759.html>

8 months agowolfSSL: Make it more obvious that Subject Alternative Name support is mandatory
Fabian Keil [Sun, 31 Mar 2024 11:50:02 +0000 (13:50 +0200)]
wolfSSL: Make it more obvious that Subject Alternative Name support is mandatory

8 months agoAdd Juliusz Sosinowicz as contributor
Fabian Keil [Sun, 31 Mar 2024 11:15:33 +0000 (13:15 +0200)]
Add Juliusz Sosinowicz as contributor

8 months agowolfSSL: Include wolfssl/openssl/pem.h
Fabian Keil [Sun, 31 Mar 2024 11:11:59 +0000 (13:11 +0200)]
wolfSSL: Include wolfssl/openssl/pem.h

Apparently this is needed on some systems including Linux Mint 21.2.

Reported by by Juliusz Sosinowicz.

8 months agowolfSSL: Use WOLFSSL_X509_V_OK instead of X509_V_OK
Fabian Keil [Sun, 31 Mar 2024 10:54:25 +0000 (12:54 +0200)]
wolfSSL: Use WOLFSSL_X509_V_OK instead of X509_V_OK

They have the same value but X509_V_OK may need
an additional header.

Reported by withoutname in #1765.

9 months agoprivoxy-log-parser: Bump copyright
Fabian Keil [Sun, 17 Mar 2024 18:00:25 +0000 (19:00 +0100)]
privoxy-log-parser: Bump copyright

9 months agoprivoxy-log-parser: Highlight 'Keeping chunk offset at 0 despite flushing 31 bytes.'
Fabian Keil [Sun, 17 Mar 2024 18:00:05 +0000 (19:00 +0100)]
privoxy-log-parser: Highlight 'Keeping chunk offset at 0 despite flushing 31 bytes.'

9 months agohandle_established_connection(): Add a period to a log message
Fabian Keil [Sun, 17 Mar 2024 17:59:35 +0000 (18:59 +0100)]
handle_established_connection(): Add a period to a log message

9 months agoAdd test scenario acl-destination-permitted
Fabian Keil [Fri, 10 Jun 2022 15:56:44 +0000 (17:56 +0200)]
Add test scenario acl-destination-permitted

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario acl-destination-denied
Fabian Keil [Fri, 10 Jun 2022 15:45:12 +0000 (17:45 +0200)]
Add test scenario acl-destination-denied

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario acl-ip-address-denied
Fabian Keil [Fri, 10 Jun 2022 15:15:52 +0000 (17:15 +0200)]
Add test scenario acl-ip-address-denied

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario acl-ip-address-permitted
Fabian Keil [Fri, 10 Jun 2022 15:15:42 +0000 (17:15 +0200)]
Add test scenario acl-ip-address-permitted

Sponsored by: Privoxy project funds collected at SPI

9 months agotests/cts: When there's lots of POST data, read it from a file
Roland Rosenfeld [Wed, 1 Jun 2022 11:26:55 +0000 (13:26 +0200)]
tests/cts: When there's lots of POST data, read it from a file

... instead of the command line (two more tests affected).

9 months agotests/cts: When there's lots of POST data, read it from a file
Fabian Keil [Tue, 24 May 2022 06:07:40 +0000 (08:07 +0200)]
tests/cts: When there's lots of POST data, read it from a file

... instead of the command line.

Makes it less likely that the curl executions fails due
to the argument list being too long.

Reported by: Roland

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario chunked-transfer-encoding-https
Fabian Keil [Wed, 10 Mar 2021 15:05:04 +0000 (16:05 +0100)]
Add test scenario chunked-transfer-encoding-https

Sponsored by: Privoxy project funds collected at SPI

9 months agoTest scenario chunked-transfer-encoding: Skip tests that require 'writesize' support
Fabian Keil [Sun, 17 Mar 2024 18:11:19 +0000 (19:11 +0100)]
Test scenario chunked-transfer-encoding: Skip tests that require 'writesize' support

... in the curl test framework as the patch hasn't been upstreamed yet.

9 months agoAdd test scenario chunked-transfer-encoding
Fabian Keil [Sat, 23 Jan 2021 14:22:03 +0000 (15:22 +0100)]
Add test scenario chunked-transfer-encoding

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario blocked-https-requests
Fabian Keil [Tue, 8 Feb 2022 12:22:11 +0000 (13:22 +0100)]
Add test scenario blocked-https-requests

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario gif-deanimation
Fabian Keil [Sat, 6 Feb 2021 10:57:24 +0000 (11:57 +0100)]
Add test scenario gif-deanimation

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario client-tags
Fabian Keil [Sun, 28 Mar 2021 09:09:29 +0000 (11:09 +0200)]
Add test scenario client-tags

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario client-body-tagger-https
Fabian Keil [Sun, 28 Mar 2021 01:05:37 +0000 (03:05 +0200)]
Add test scenario client-body-tagger-https

Sponsored by: Robert Klemme

9 months agoAdd test scenario client-body-tagger
Fabian Keil [Sat, 27 Mar 2021 14:04:11 +0000 (15:04 +0100)]
Add test scenario client-body-tagger

Sponsored by: Robert Klemme

9 months agoAdd test scenario client-body-filter-https
Fabian Keil [Fri, 26 Mar 2021 11:01:28 +0000 (12:01 +0100)]
Add test scenario client-body-filter-https

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario client-body-filter
Fabian Keil [Fri, 26 Mar 2021 06:06:07 +0000 (07:06 +0100)]
Add test scenario client-body-filter

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario forward-to-socks-proxy
Fabian Keil [Tue, 9 Mar 2021 16:40:54 +0000 (17:40 +0100)]
Add test scenario forward-to-socks-proxy

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario forward-to-http-proxy
Fabian Keil [Tue, 9 Mar 2021 09:16:06 +0000 (10:16 +0100)]
Add test scenario forward-to-http-proxy

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario pac-file-delivery
Fabian Keil [Fri, 5 Mar 2021 07:19:04 +0000 (08:19 +0100)]
Add test scenario pac-file-delivery

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario user-manual-https
Fabian Keil [Wed, 3 Feb 2021 10:41:43 +0000 (11:41 +0100)]
Add test scenario user-manual-https

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario user-manual-http
Fabian Keil [Wed, 3 Feb 2021 10:36:51 +0000 (11:36 +0100)]
Add test scenario user-manual-http

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario gzip compression
Fabian Keil [Thu, 28 Jan 2021 13:56:59 +0000 (14:56 +0100)]
Add test scenario gzip compression

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario header-filters
Fabian Keil [Fri, 22 Jan 2021 15:32:10 +0000 (16:32 +0100)]
Add test scenario header-filters

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd test scenario content-filters
Fabian Keil [Tue, 19 Jan 2021 17:54:50 +0000 (18:54 +0100)]
Add test scenario content-filters

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd upstream-tests scenario
Fabian Keil [Sun, 10 Jan 2021 15:18:17 +0000 (16:18 +0100)]
Add upstream-tests scenario

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd tests for redirects for https-inspected requests
Fabian Keil [Sun, 10 Jan 2021 09:17:30 +0000 (10:17 +0100)]
Add tests for redirects for https-inspected requests

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd redirect tests
Fabian Keil [Sun, 10 Jan 2021 08:48:35 +0000 (09:48 +0100)]
Add redirect tests

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd tests for destination rewrite
Fabian Keil [Sat, 9 Jan 2021 18:54:09 +0000 (19:54 +0100)]
Add tests for destination rewrite

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd tests for rewrite behind the client's back with https
Fabian Keil [Sun, 10 Jan 2021 03:37:16 +0000 (04:37 +0100)]
Add tests for rewrite behind the client's back with https

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd tests for client-header-order with https-inspection enabled
Fabian Keil [Sat, 9 Jan 2021 18:05:53 +0000 (19:05 +0100)]
Add tests for client-header-order with https-inspection enabled

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd client-header-order tests
Fabian Keil [Sat, 9 Jan 2021 15:49:29 +0000 (16:49 +0100)]
Add client-header-order tests

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd a README for the tests based on the curl test suite (cts)
Fabian Keil [Sat, 27 Feb 2021 09:54:18 +0000 (10:54 +0100)]
Add a README for the tests based on the curl test suite (cts)

Contains improvements made after feedback from Roland.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd run-privoxy-tests.sh
Fabian Keil [Sun, 10 Jan 2021 05:50:06 +0000 (06:50 +0100)]
Add run-privoxy-tests.sh

... which takes care of starting Privoxy before running tests.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd logs directory for the tests based on the curl test suite
Fabian Keil [Fri, 22 Jan 2021 08:25:39 +0000 (09:25 +0100)]
Add logs directory for the tests based on the curl test suite

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd a generated test manifest file
Fabian Keil [Sat, 12 Jul 2014 12:15:23 +0000 (14:15 +0200)]
Add a generated test manifest file

.. to skip curl tests that aren't relevant for Privoxy or
are known not to work for other reasons.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd a script to generate a runtests.pl exclude file for Privoxy
Fabian Keil [Sat, 17 Nov 2012 14:02:18 +0000 (15:02 +0100)]
Add a script to generate a runtests.pl exclude file for Privoxy

curl tests that are known not to work with Privoxy are skipped.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd runtests-wrapper.sh
Fabian Keil [Sat, 9 Jan 2021 15:49:08 +0000 (16:49 +0100)]
Add runtests-wrapper.sh

A wrapper around curl's runtests.pl.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd privoxy-runtests.pm
Fabian Keil [Sun, 15 Jun 2014 16:28:51 +0000 (18:28 +0200)]
Add privoxy-runtests.pm

Overwrites some of the functions used by curl's runtests.pl
to let it properly deal with Privoxy being used as proxy.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAdd Fabrice Fontaine as contributor
Fabian Keil [Sun, 17 Mar 2024 13:11:01 +0000 (14:11 +0100)]
Add Fabrice Fontaine as contributor

9 months agoGNUmakefile.in: Don't exit if configuration files are installed as root
Fabrice Fontaine [Sun, 17 Mar 2024 11:36:31 +0000 (12:36 +0100)]
GNUmakefile.in: Don't exit if configuration files are installed as root

... as this can be considered acceptable when cross-compiling
Privoxy inside an autobuilder with only a root user.

9 months agoDisable fast-redirect for syndication.twitter.com/
Fabian Keil [Wed, 28 Feb 2024 16:52:37 +0000 (17:52 +0100)]
Disable fast-redirect for syndication.twitter.com/

9 months agoUnblock .datenschmutz.de/
Fabian Keil [Thu, 4 Jan 2024 04:44:12 +0000 (05:44 +0100)]
Unblock .datenschmutz.de/

9 months agouser-manual: List wolfSSL as potential dependency
Fabian Keil [Thu, 11 Mar 2021 17:08:11 +0000 (18:08 +0100)]
user-manual: List wolfSSL as potential dependency

... in the 'Third-party licenses and copyrights' section.

Sponsored by: Privoxy project funds collected at SPI

9 months agoAllow to use wolfSSL for https inspection
Fabian Keil [Tue, 12 Jan 2021 07:12:38 +0000 (08:12 +0100)]
Allow to use wolfSSL for https inspection

It's licensed under GPlv2 or later and unlike mbedTLS
there don't seem to be plans to change the license.

As a bonus, wolfSSL supports TLS 1.3 and can be significantly
faster than mbedTLS. Mainly tested on ElectroBSD amd64 where
it can compete with OpenSSL and LibreSSL:
https://www.fabiankeil.de/gehacktes/privoxy-tls-benchmarks/

To enable the support, install wolfSSL and run ./configure
with the --with-wolfssl option.

Privoxy users and packagers that currently build Privoxy
binaries with mbedTLS may want to consider using wolfSSL
in the future once it has been properly tested.

Sponsored by: Privoxy project funds collected at SPI

11 months agoMerge Debian 3.0.34-2/3 into Upstream tree.
Roland Rosenfeld [Tue, 2 Jan 2024 18:29:06 +0000 (19:29 +0100)]
Merge Debian 3.0.34-2/3 into Upstream tree.

This fixes the build dependency on libpcre2-dev, since upstream alreay
uses pcre2.

11 months agoRemove ./ prefix from tarball-dist files.
Roland Rosenfeld [Tue, 2 Jan 2024 18:21:44 +0000 (19:21 +0100)]
Remove ./ prefix from tarball-dist files.

12 months agoBump copyright
Fabian Keil [Mon, 18 Dec 2023 13:58:37 +0000 (14:58 +0100)]
Bump copyright

12 months agoAdd Florian Weimer as contributor
Fabian Keil [Mon, 18 Dec 2023 13:07:12 +0000 (14:07 +0100)]
Add Florian Weimer as contributor

12 months agoconfigure.in: Fix argument types in gmtime_r() and localtime_r() probes
Fabian Keil [Tue, 19 Dec 2023 10:48:37 +0000 (11:48 +0100)]
configure.in: Fix argument types in gmtime_r() and localtime_r() probes

Otherwise these probes always fail with stricter compilers
even if there is C library support for these functions.

Patch submitted by Florian Weimer in SF#149.

12 months agoreceive_encrypted_request_headers(): Add periods to a couple of log messages
Fabian Keil [Sun, 26 Nov 2023 00:16:39 +0000 (01:16 +0100)]
receive_encrypted_request_headers(): Add periods to a couple of log messages

13 months agoBump copyright
Fabian Keil [Thu, 16 Nov 2023 13:27:17 +0000 (14:27 +0100)]
Bump copyright

13 months agoAdd Ingo Blechschmidt as contributor
Fabian Keil [Thu, 16 Nov 2023 13:17:42 +0000 (14:17 +0100)]
Add Ingo Blechschmidt as contributor

13 months agoFix socks4 and socks4a support under glibc's source fortification
Ingo Blechschmidt [Sun, 5 Nov 2023 22:43:54 +0000 (23:43 +0100)]
Fix socks4 and socks4a support under glibc's source fortification

With glib'c source fortification, gcc offers the compilation warning

    gateway.c: In function 'socks4_connect':
    gateway.c:840:4: warning: 'strlcpy' writing 4988 bytes into a region of size 1 overflows the destination
      840 |    strlcpy(&(c->userid), socks_userid, sizeof(buf) - sizeof(struct socks_op));
  |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    gateway.c:112:9: note: destination object 'userid' of size 1
      112 |    char userid;               /* first byte of userid */
  |         ^~~~~~

resulting in a runtime abort() when using a socks4 or socks4a upstream proxy:

    $ privoxy --no-daemon <(echo 'forward-socks4 / 127.0.0.1:9050 .')
    7fef77483740 Info: Privoxy version 3.0.34
    7fef77483740 Info: Program name: privoxy
    *** buffer overflow detected ***: terminated
    rc: line 3: 321835 Aborted    (core dumped) privoxy --no-daemon <(echo 'forward-socks4 / 127.0.0.1:9050 .')

Despite the warning, the strlcpy() call in question is fine: gcc
misidentifies the size of the destination buffer, estimating to hold
only a single char while in fact the buffer stretches beyond the end of
the struct socks_op.

This commit fixes this issue in a way which is in line with the second
strlcpy() call in the socks4_connect(). Alternatively, we could also
remove the padding member and promote userid to a trailing flexible array
member. However, this would necessitate further adjustments because that
way the size of struct socks_op would change.

The issue was originally reported in the NixOS issue tracker at

    https://github.com/NixOS/nixpkgs/issues/265654

prompted by an upgrade of glibc from 2.37-39 to 2.38-0, and the fix is
joint work with @esclear and @richi235.

13 months agocreate_client_ssl_connection(): Make it more obviours from an error message that...
Fabian Keil [Mon, 30 Oct 2023 20:13:50 +0000 (21:13 +0100)]
create_client_ssl_connection(): Make it more obviours from an error message that a function failed

13 months agoprivoxy-log-parser: Highlight: 'Couldn't deliver the error message for [...]'
Fabian Keil [Fri, 27 Oct 2023 19:18:51 +0000 (21:18 +0200)]
privoxy-log-parser: Highlight: 'Couldn't deliver the error message for [...]'

13 months agoBump copyright
Fabian Keil [Tue, 17 Oct 2023 16:44:08 +0000 (18:44 +0200)]
Bump copyright

13 months agoprivoxy-log-parser: Bump copyright
Fabian Keil [Mon, 16 Oct 2023 19:22:40 +0000 (21:22 +0200)]
privoxy-log-parser: Bump copyright

13 months agoprivoxy-log-parser: Highlight 'Failed to accept() incoming connection: Software cause...
Fabian Keil [Mon, 16 Oct 2023 19:10:31 +0000 (21:10 +0200)]
privoxy-log-parser: Highlight 'Failed to accept() incoming connection: Software caused connection abort'

13 months agolisten_loop(): Improve an error message
Fabian Keil [Mon, 16 Oct 2023 19:09:07 +0000 (21:09 +0200)]
listen_loop(): Improve an error message

13 months agoBump copyright
Fabian Keil [Sun, 10 Sep 2023 08:16:30 +0000 (10:16 +0200)]
Bump copyright

13 months agoUse stringify() instead of section_target()
Fabian Keil [Sun, 10 Sep 2023 07:44:10 +0000 (09:44 +0200)]
Use stringify() instead of section_target()

... and remove section_target(). Like the XXX comment suggested
this could be done my moving the hash into the templates which
seems preferable anyway.

14 months agoBlock requests to secure-eu.nmrodam.com/
Fabian Keil [Thu, 28 Sep 2023 16:37:22 +0000 (18:37 +0200)]
Block requests to secure-eu.nmrodam.com/

14 months agoBlock requests to o2.mouseflow.com/
Fabian Keil [Sat, 9 Sep 2023 11:27:24 +0000 (13:27 +0200)]
Block requests to o2.mouseflow.com/

14 months agouagen: Bump copyright
Fabian Keil [Sun, 8 Oct 2023 14:21:42 +0000 (16:21 +0200)]
uagen: Bump copyright

14 months agouagen: Bump version
Fabian Keil [Sun, 8 Oct 2023 14:11:06 +0000 (16:11 +0200)]
uagen: Bump version

14 months agouagen: Bump BROWSER_VERSION and BROWSER_REVISION
Fabian Keil [Sun, 8 Oct 2023 14:09:12 +0000 (16:09 +0200)]
uagen: Bump BROWSER_VERSION and BROWSER_REVISION

... to match Firefox ESR 115.

I don't know why the BROWSER_REVISION is still at 109
but that's what Firefox ESR 115 uses when compiled
on ElectroBSD.

14 months agoDisable fast-redirects for /wp-content/plugins/pdf-viewer-for-elementor
Fabian Keil [Mon, 11 Sep 2023 18:10:56 +0000 (20:10 +0200)]
Disable fast-redirects for /wp-content/plugins/pdf-viewer-for-elementor

15 months agoBump MAX_FILTER_TYPES
Fabian Keil [Sat, 9 Sep 2023 09:59:25 +0000 (11:59 +0200)]
Bump MAX_FILTER_TYPES

... which should have been done in d128e6aa41 when introducing
the client-body-tagger{} action.

Prevents an assertion in cgi_edit_actions_for_url() from triggering
after e32d03e0 when using the CGI editor with assertions enabled.

15 months agoAdd Aaron Li as contributor
Fabian Keil [Sat, 9 Sep 2023 07:06:44 +0000 (09:06 +0200)]
Add Aaron Li as contributor

15 months agoAdd missing client-body-tagger data to the action_type_info[] struct
Fabian Keil [Sat, 9 Sep 2023 06:55:33 +0000 (08:55 +0200)]
Add missing client-body-tagger data to the action_type_info[] struct

... so lookups based on the action index work correctly again.

Prevents assertion failures or segfaults when trying to edit
an action file with the CGI editor.

The type of failure depended on whether or not assertions
were enabled and on whether or not Privoxy had been compiled
with FEATURE_EXTERNAL_FILTERS.

Regression introduced in Privoxy 3.0.34.

Patch submitted by Aaron Li in #940.

15 months agocgi_edit_actions_for_url(): Wrap line sooner
Fabian Keil [Sat, 9 Sep 2023 06:41:37 +0000 (08:41 +0200)]
cgi_edit_actions_for_url(): Wrap line sooner

15 months agoaction_render_string_actions_template(): Assert that the multi action index is valid
Fabian Keil [Sat, 9 Sep 2023 06:17:52 +0000 (08:17 +0200)]
action_render_string_actions_template(): Assert that the multi action index is valid

15 months agocgi_edit_actions_for_url(): Assert that the multi action index is valid
Fabian Keil [Sat, 9 Sep 2023 06:16:08 +0000 (08:16 +0200)]
cgi_edit_actions_for_url(): Assert that the multi action index is valid

15 months agocgi_edit_actions_for_url(): Add missing space
Fabian Keil [Sat, 9 Sep 2023 06:14:31 +0000 (08:14 +0200)]
cgi_edit_actions_for_url(): Add missing space

15 months agoaction_render_string_actions_template: Fix spelling in description and re-flow
Fabian Keil [Sat, 9 Sep 2023 06:11:30 +0000 (08:11 +0200)]
action_render_string_actions_template: Fix spelling in description and re-flow

15 months agoaction_render_string_actions_template(): Adjust space around function parameters
Fabian Keil [Sat, 9 Sep 2023 06:08:34 +0000 (08:08 +0200)]
action_render_string_actions_template(): Adjust space around function parameters

16 months agoAdd a regression test for left-anchored path patterns
Fabian Keil [Sun, 27 Aug 2023 10:39:22 +0000 (12:39 +0200)]
Add a regression test for left-anchored path patterns

16 months agopcre2 compile_pattern(): Actually pass the anchored pattern to pcre2_compile()
Fabian Keil [Sun, 27 Aug 2023 10:26:02 +0000 (12:26 +0200)]
pcre2 compile_pattern(): Actually pass the anchored pattern to pcre2_compile()

Previously the un-anchoring pattern was compiled resulting
in incorrect matches.

For example requests to:

    https://www.privoxy.org/user-manual/config.html

were redirected because of the default.action section:

    {+redirect{http://config.privoxy.org/}}
    # Sticky Actions = +redirect{http://config.privoxy.org/}
    # URL = http://www.privoxy.org/config
    # Redirected URL = http://www.privoxy.org/config
    # Redirect Destination = http://config.privoxy.org/
    .privoxy.org/config

As the path pattern is left-anchored it should not match.