privoxy.git
13 years agoFix an invalid free when compiled with FEATURE_GRACEFUL_TERMINATION and shut down...
Fabian Keil [Thu, 3 Mar 2011 14:41:29 +0000 (14:41 +0000)]
Fix an invalid free when compiled with FEATURE_GRACEFUL_TERMINATION and shut down through config.privoxy.org/die

13 years agoImprove a comment in load_one_actions_file()
Fabian Keil [Thu, 3 Mar 2011 14:39:57 +0000 (14:39 +0000)]
Improve a comment in load_one_actions_file()

13 years agoMake two fatal error message in load_one_actions_file() more descriptive
Fabian Keil [Thu, 3 Mar 2011 14:39:34 +0000 (14:39 +0000)]
Make two fatal error message in load_one_actions_file() more descriptive

13 years agoIn load_one_actions_file(), don't limit the actions_buf to BUFFER_SIZE bytes.
Fabian Keil [Thu, 3 Mar 2011 14:39:13 +0000 (14:39 +0000)]
In load_one_actions_file(), don't limit the actions_buf to BUFFER_SIZE bytes.

13 years agoDon't enforce a logical line length limit in read_config_line()
Fabian Keil [Thu, 3 Mar 2011 14:38:36 +0000 (14:38 +0000)]
Don't enforce a logical line length limit in read_config_line()

It means the caller has to free the buffer, but we can live with that.

13 years agoRemove duplicated 'the' in a comment
Fabian Keil [Thu, 3 Mar 2011 14:22:39 +0000 (14:22 +0000)]
Remove duplicated 'the' in a comment

13 years agoRemove duplicated 'the'
Fabian Keil [Thu, 3 Mar 2011 14:22:12 +0000 (14:22 +0000)]
Remove duplicated 'the'

13 years agoAdditionally accept ISO 8601 time stamps.
Fabian Keil [Sun, 20 Feb 2011 13:17:16 +0000 (13:17 +0000)]
Additionally accept ISO 8601 time stamps.

13 years agoBump copyright.
Fabian Keil [Sat, 19 Feb 2011 13:59:59 +0000 (13:59 +0000)]
Bump copyright.

13 years agoIn load_action_files(), don't check_for_forbidden_characters() if it has already...
Fabian Keil [Sat, 19 Feb 2011 13:59:40 +0000 (13:59 +0000)]
In load_action_files(), don't check_for_forbidden_characters() if it has already been done through enlist_new_test()

13 years agoIn the --help output, include a list of supported test types and their default levels.
Fabian Keil [Sat, 19 Feb 2011 13:59:20 +0000 (13:59 +0000)]
In the --help output, include a list of supported test types and their default levels.

13 years agoRephrase the descriptions of the forwarder_types SOCKS_4A and SOCKS_5
Fabian Keil [Sat, 19 Feb 2011 13:58:48 +0000 (13:58 +0000)]
Rephrase the descriptions of the forwarder_types SOCKS_4A and SOCKS_5

13 years agoUse an enum for the forwarder_type
Fabian Keil [Sat, 19 Feb 2011 13:56:55 +0000 (13:56 +0000)]
Use an enum for the forwarder_type

13 years agoUse an enum for the SOCKS4 reply field values
Fabian Keil [Sat, 19 Feb 2011 13:56:22 +0000 (13:56 +0000)]
Use an enum for the SOCKS4 reply field values

13 years agoRename then SOCKS4 defines from SOCKS_REQUEST_FOO to SOCKS4_REQUEST_FOO
Fabian Keil [Sat, 19 Feb 2011 13:55:57 +0000 (13:55 +0000)]
Rename then SOCKS4 defines from SOCKS_REQUEST_FOO to SOCKS4_REQUEST_FOO

They aren't used for SOCKS5.

13 years agoUse an enum for the SOCKS5 reply field
Fabian Keil [Sat, 19 Feb 2011 13:54:00 +0000 (13:54 +0000)]
Use an enum for the SOCKS5 reply field

13 years agoIn block_url(), consistently use the block reason "Request blocked by Privoxy"
Fabian Keil [Sat, 19 Feb 2011 13:53:14 +0000 (13:53 +0000)]
In block_url(), consistently use the block reason "Request blocked by Privoxy"

In two places the reason was "Request for blocked URL" which
hides the fact that the request got blocked by Privoxy and
isn't necessarly correct as the block may be due to tags.

13 years agoSlightly refactor server_last_modified() to remove useless gmtime*() calls
Fabian Keil [Mon, 14 Feb 2011 16:11:34 +0000 (16:11 +0000)]
Slightly refactor server_last_modified() to remove useless gmtime*() calls

13 years agoIn get_content_type(), also recognize '.jpeg' as JPEG extension
Fabian Keil [Mon, 14 Feb 2011 16:07:52 +0000 (16:07 +0000)]
In get_content_type(), also recognize '.jpeg' as JPEG extension

13 years agoAdd '.png' to the list of recognized file extenstions in get_content_type()
Fabian Keil [Mon, 14 Feb 2011 16:07:32 +0000 (16:07 +0000)]
Add '.png' to the list of recognized file extenstions in get_content_type()

13 years agoMore clean-ups for cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:07:11 +0000 (16:07 +0000)]
More clean-ups for cgi_send_user_manual()

13 years agoFactor get_content_type() out of cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:06:37 +0000 (16:06 +0000)]
Factor get_content_type() out of cgi_send_user_manual()

13 years agoIn cgi_send_user_manual(), log when rejecting a file name due to '/' or '..'
Fabian Keil [Mon, 14 Feb 2011 16:05:37 +0000 (16:05 +0000)]
In cgi_send_user_manual(), log when rejecting a file name due to '/' or '..'

While at it, improve a comment.

13 years agoSlightly clean up the filename handling in cgi_send_user_manual()
Fabian Keil [Mon, 14 Feb 2011 16:04:55 +0000 (16:04 +0000)]
Slightly clean up the filename handling in cgi_send_user_manual()

13 years agoIn load_file(), log a message if opening a file failed
Fabian Keil [Mon, 14 Feb 2011 16:03:53 +0000 (16:03 +0000)]
In load_file(), log a message if opening a file failed

The CGI error message alone isn't too helpful.

13 years agoIn connection_destination_matches(), improve two log messages to help understand...
Fabian Keil [Mon, 14 Feb 2011 16:03:03 +0000 (16:03 +0000)]
In connection_destination_matches(), improve two log messages to help understand why the destinations don't match

13 years agoIn load_one_actions_file(), use an enum for the mode.
Fabian Keil [Mon, 14 Feb 2011 16:01:20 +0000 (16:01 +0000)]
In load_one_actions_file(), use an enum for the mode.

13 years agoMove the site-specific block pattern section below the one for the generic patterns.
Fabian Keil [Thu, 10 Feb 2011 22:30:41 +0000 (22:30 +0000)]
Move the site-specific block pattern section below the one for the generic patterns.

For requests that are matched in both, showing the block
reason for the domain seems to be more useful than showing
the one for the generic pattern.

13 years agoBlock 'www91.intel.com/' which is used by Omniture.
Fabian Keil [Thu, 10 Feb 2011 22:26:17 +0000 (22:26 +0000)]
Block 'www91.intel.com/' which is used by Omniture.

Reported by Adam Piggott in #3167370.

13 years agoDisable the handle-as-empty-doc-returns-ok option and mark it as deprecated.
Fabian Keil [Thu, 10 Feb 2011 22:25:32 +0000 (22:25 +0000)]
Disable the handle-as-empty-doc-returns-ok option and mark it as deprecated.

While at it, move the "Notes" to the traditional location.

Reminded by tceverling in #2790091.

13 years agoAdd ".ivwbox.de/" to the "Cross-site user tracking" section.
Fabian Keil [Thu, 10 Feb 2011 22:21:16 +0000 (22:21 +0000)]
Add ".ivwbox.de/" to the "Cross-site user tracking" section.

Reported by Nettozahler in #3172525.

13 years agoUnblock and fast-redirect ".awin1.com/.*=http://"
Fabian Keil [Thu, 10 Feb 2011 22:20:38 +0000 (22:20 +0000)]
Unblock and fast-redirect ".awin1.com/.*=http://"

Reported by Adam Piggott in #3170921.

13 years agoActually the items are sorted, just not by priority.
Fabian Keil [Thu, 10 Feb 2011 22:18:30 +0000 (22:18 +0000)]
Actually the items are sorted, just not by priority.

13 years agoAdd #89: show multiple block reasons on the blocked page
Fabian Keil [Thu, 10 Feb 2011 22:16:55 +0000 (22:16 +0000)]
Add #89: show multiple block reasons on the blocked page

13 years agoBlock "b.collective-media.net/".
Fabian Keil [Mon, 24 Jan 2011 18:16:33 +0000 (18:16 +0000)]
Block "b.collective-media.net/".

13 years agoFix spelling.
Fabian Keil [Mon, 24 Jan 2011 18:12:44 +0000 (18:12 +0000)]
Fix spelling.

13 years agoWiden the Debian popcon exception to "qa.debian.org/popcon".
Fabian Keil [Sat, 22 Jan 2011 12:36:52 +0000 (12:36 +0000)]
Widen the Debian popcon exception to "qa.debian.org/popcon".

Seen in Debian's 05_default_action.dpatch by Roland Rosenfeld:
http://patch-tracker.debian.org/patch/series/view/privoxy/3.0.16-1/05_defaut_action.dpatch

13 years agoIntroduce a MAN_PAGE variable that defaults to privoxy.1.
Fabian Keil [Sat, 22 Jan 2011 12:33:11 +0000 (12:33 +0000)]
Introduce a MAN_PAGE variable that defaults to privoxy.1.

The Debian package uses section 8 for the man page and this should simplify the patch.

13 years agoFix various typos. Apparently I can't spell length too well.
Fabian Keil [Sat, 22 Jan 2011 12:30:22 +0000 (12:30 +0000)]
Fix various typos. Apparently I can't spell length too well.

Fixes taken from Debian's 29_typos.dpatch by Roland Rosenfeld:
http://patch-tracker.debian.org/patch/series/view/privoxy/3.0.16-1/29_typos.dpatch

13 years agoAdd a note that #13 is already being worked on and not particularly promising for...
Fabian Keil [Sat, 15 Jan 2011 13:12:45 +0000 (13:12 +0000)]
Add a note that #13 is already being worked on and not particularly promising for most users.

13 years agoAdd #88: Investigate if there's a Perl module that Privoxy-Regression-Test could...
Fabian Keil [Sat, 15 Jan 2011 13:11:24 +0000 (13:11 +0000)]
Add #88: Investigate if there's a Perl module that Privoxy-Regression-Test could optionally use to keep connections alive.

13 years agoDitch an already disabled workaround for a mysterious PHP bug in client_accept_encodi...
Fabian Keil [Fri, 14 Jan 2011 21:35:44 +0000 (21:35 +0000)]
Ditch an already disabled workaround for a mysterious PHP bug in client_accept_encoding().

13 years agoAccept and highlight: File modification detected: /usr/local/etc/privoxy/user-agent...
Fabian Keil [Fri, 14 Jan 2011 19:47:53 +0000 (19:47 +0000)]
Accept and highlight: File modification detected: /usr/local/etc/privoxy/user-agent.action

13 years agoRephrase a log message in any_loaded_file_changed().
Fabian Keil [Fri, 14 Jan 2011 19:47:16 +0000 (19:47 +0000)]
Rephrase a log message in any_loaded_file_changed().

Log messages should start with constant strings to simplify pattern matching.

13 years agoBlock ".gemius.pl/" which only seems to be used for user tracking.
Fabian Keil [Fri, 14 Jan 2011 19:34:04 +0000 (19:34 +0000)]
Block ".gemius.pl/" which only seems to be used for user tracking.

Reported by johnd16 in #3002731. Additional input from Lee and movax.

13 years agoUpdate the socket-timout 'Notes' section.
Fabian Keil [Sun, 9 Jan 2011 12:10:34 +0000 (12:10 +0000)]
Update the socket-timout 'Notes' section.

The socks-related limitation is gone now, even though
'next release' wasn't a particular good estimate.

13 years agoAccept and highlight: Client request arrived in time on socket 21.
Fabian Keil [Sun, 9 Jan 2011 12:09:21 +0000 (12:09 +0000)]
Accept and highlight: Client request arrived in time on socket 21.

13 years agoLet socks4_connect enforce the socket timeout for the negotiation response as well.
Fabian Keil [Sun, 9 Jan 2011 12:08:52 +0000 (12:08 +0000)]
Let socks4_connect enforce the socket timeout for the negotiation response as well.

13 years agoLet socks5_connect enforce the socket timeout for the negotiation response as well.
Fabian Keil [Sun, 9 Jan 2011 12:08:35 +0000 (12:08 +0000)]
Let socks5_connect enforce the socket timeout for the negotiation response as well.

13 years agoRephrase a log message in serve(). Client request arrival should be differentiated...
Fabian Keil [Sun, 9 Jan 2011 12:08:04 +0000 (12:08 +0000)]
Rephrase a log message in serve(). Client request arrival should be differentiated from closed client connections now.

13 years agoIn get_actions(), fix the "temporary" backwards compatibility hack to accept block...
Fabian Keil [Sun, 9 Jan 2011 12:00:19 +0000 (12:00 +0000)]
In get_actions(), fix the "temporary" backwards compatibility hack to accept block actions without reason.

It also covered other actions that should be rejected as invalid.
Reported by Billy Crook.

13 years agoIn listen_loop(), reload the configuration files after accepting a new connection...
Fabian Keil [Sun, 2 Jan 2011 12:17:03 +0000 (12:17 +0000)]
In listen_loop(), reload the configuration files after accepting a new connection instead of before.

Previously the first connection that arrived after a configuration
change would still be handled with the old configuration.

13 years agoIn chat()'s receive-data loop, skip the socket_is_still_alive(csp->cfd) check if...
Fabian Keil [Sun, 2 Jan 2011 11:57:45 +0000 (11:57 +0000)]
In chat()'s receive-data loop, skip the socket_is_still_alive(csp->cfd) check if we aren't buffering.

As Lee noticed, the check can measurable affect the performance.

13 years agoDon't log whether or not a request on a client connection that isn't kept alive has...
Fabian Keil [Fri, 31 Dec 2010 14:57:00 +0000 (14:57 +0000)]
Don't log whether or not a request on a client connection that isn't kept alive has been crunched.

It doesn't actually matter anymore.

13 years agoDitch a pointless NULL-pointer check in load_trustfile().
Fabian Keil [Fri, 31 Dec 2010 14:53:09 +0000 (14:53 +0000)]
Ditch a pointless NULL-pointer check in load_trustfile().

csp already got dereferenced earlier and can't be NULL.
Spotted by cppcheck.

13 years agoIn serve(), log if a client connection isn't reused due to a configuration file change.
Fabian Keil [Sun, 26 Dec 2010 16:20:08 +0000 (16:20 +0000)]
In serve(), log if a client connection isn't reused due to a configuration file change.

13 years agoFix spelling in a comment
Fabian Keil [Sun, 26 Dec 2010 16:18:52 +0000 (16:18 +0000)]
Fix spelling in a comment

13 years agoLet mark_server_socket_tainted() always mark the server socket tainted, just don...
Fabian Keil [Sun, 26 Dec 2010 16:18:30 +0000 (16:18 +0000)]
Let mark_server_socket_tainted() always mark the server socket tainted, just don't talk about it in cases where it has no effect.

It doesn't change Privoxy's behaviour, but makes understanding
the log file easier.

13 years agoKnock a debug message in serve() up a notch. Bam!
Fabian Keil [Sun, 26 Dec 2010 16:13:47 +0000 (16:13 +0000)]
Knock a debug message in serve() up a notch. Bam!

13 years agoDon't keep the client connection alive if any configuration file changed since the...
Fabian Keil [Sun, 26 Dec 2010 15:30:28 +0000 (15:30 +0000)]
Don't keep the client connection alive if any configuration file changed since the time the connection came in.

This is closer to Privoxy's behaviour before keep-alive support
for client connection has been added and also less confusing in
general.

13 years agoTreat all Content-Type header values containing the pattern 'script' as a sign of...
Fabian Keil [Sat, 18 Dec 2010 12:56:33 +0000 (12:56 +0000)]
Treat all Content-Type header values containing the pattern 'script' as a sign of text.

Reported by pribog in #3134970.

13 years agoAdd 86) and 87): Implement server-body-tagger and client-body-tagger actions.
Fabian Keil [Sat, 18 Dec 2010 12:09:43 +0000 (12:09 +0000)]
Add 86) and 87): Implement server-body-tagger and client-body-tagger actions.

13 years agoBe more specific about what 80) is all about.
Fabian Keil [Tue, 14 Dec 2010 18:56:11 +0000 (18:56 +0000)]
Be more specific about what 80) is all about.

13 years agoBump generated Firefox version to 3.6.13.
Fabian Keil [Sat, 11 Dec 2010 15:54:30 +0000 (15:54 +0000)]
Bump generated Firefox version to 3.6.13.

13 years agoWhite-space fix for the previous commit.
Fabian Keil [Sat, 11 Dec 2010 15:44:55 +0000 (15:44 +0000)]
White-space fix for the previous commit.

13 years agoImplement a --unbreak-lines-only option to try to revert MUA breakage.
Fabian Keil [Sat, 11 Dec 2010 15:40:29 +0000 (15:40 +0000)]
Implement a --unbreak-lines-only option to try to revert MUA breakage.

13 years agoUse a local scalar for the file handle.
Fabian Keil [Sat, 11 Dec 2010 15:36:47 +0000 (15:36 +0000)]
Use a local scalar for the file handle.

13 years agoBump version to 3.0.18 UNRELEASED.
Fabian Keil [Sat, 11 Dec 2010 15:35:41 +0000 (15:35 +0000)]
Bump version to 3.0.18 UNRELEASED.

13 years agoHopefully unbreak the dok target when using some kind of jade.
Fabian Keil [Wed, 1 Dec 2010 19:28:28 +0000 (19:28 +0000)]
Hopefully unbreak the dok target when using some kind of jade.

Reported by Lee.

13 years agoThe version that got sent out to the mailing lists
Fabian Keil [Mon, 22 Nov 2010 10:37:57 +0000 (10:37 +0000)]
The version that got sent out to the mailing lists

13 years agoMention socks5 in another part of the Tor section.
Fabian Keil [Mon, 22 Nov 2010 10:35:02 +0000 (10:35 +0000)]
Mention socks5 in another part of the Tor section.

13 years agoIn write_action_file(), reduce the scope of a fd scalar and convert an open call...
Fabian Keil [Mon, 22 Nov 2010 10:34:44 +0000 (10:34 +0000)]
In write_action_file(), reduce the scope of a fd scalar and convert an open call to use three arguments.

13 years agoStore file handles in local scalars.
Fabian Keil [Mon, 22 Nov 2010 10:34:28 +0000 (10:34 +0000)]
Store file handles in local scalars.

13 years agoAdd some CGI interface improvement tasks.
Fabian Keil [Mon, 22 Nov 2010 10:34:06 +0000 (10:34 +0000)]
Add some CGI interface improvement tasks.

13 years agoForced commit to note that the executable bits have been removed.
Fabian Keil [Mon, 22 Nov 2010 10:32:40 +0000 (10:32 +0000)]
Forced commit to note that the executable bits have been removed.

13 years agoFix wording. The webserver target actually doesn't scp anything.
Fabian Keil [Sun, 14 Nov 2010 15:02:07 +0000 (15:02 +0000)]
Fix wording. The webserver target actually doesn't scp anything.

13 years agoLet the webserver target warn about two known issues.
Fabian Keil [Sun, 14 Nov 2010 14:59:33 +0000 (14:59 +0000)]
Let the webserver target warn about two known issues.

13 years agoLet the webserver target update the user-manual symlink automatically.
Fabian Keil [Sun, 14 Nov 2010 14:48:45 +0000 (14:48 +0000)]
Let the webserver target update the user-manual symlink automatically.

As a bonus this prevents the webserver target from overwriting
whatever the user-manual symlink currently points to, usually the
documentation from the previous release.

13 years agoMake it more obvious how to open the SF shell the webserver target asks for.
Fabian Keil [Sun, 14 Nov 2010 11:37:22 +0000 (11:37 +0000)]
Make it more obvious how to open the SF shell the webserver target asks for.

13 years agoLet the webserver and web-actions targets call ssh through $SSH so the username doesn...
Fabian Keil [Sun, 14 Nov 2010 11:26:26 +0000 (11:26 +0000)]
Let the webserver and web-actions targets call ssh through $SSH so the username doesn't get dropped.

13 years agoThe traditional I-knew-there-was-something-missing-commit.
Fabian Keil [Sun, 14 Nov 2010 11:16:54 +0000 (11:16 +0000)]
The traditional I-knew-there-was-something-missing-commit.

I'm not sure why the dok target doesn't call man2html, through.

13 years agoBump version to 0.7.
Fabian Keil [Sat, 13 Nov 2010 20:37:39 +0000 (20:37 +0000)]
Bump version to 0.7.

13 years agoRegenerate with ChangeLog updates
Fabian Keil [Sat, 13 Nov 2010 20:17:52 +0000 (20:17 +0000)]
Regenerate with ChangeLog updates

13 years agoMerge ChangeLog updates
Fabian Keil [Sat, 13 Nov 2010 20:17:11 +0000 (20:17 +0000)]
Merge ChangeLog updates

13 years agoMention the recent documentation changes.
Fabian Keil [Sat, 13 Nov 2010 20:16:15 +0000 (20:16 +0000)]
Mention the recent documentation changes.

13 years agoCosmetics.
Fabian Keil [Sat, 13 Nov 2010 20:16:00 +0000 (20:16 +0000)]
Cosmetics.

13 years agoMention that Privoxy would time the hanging connections out, too.
Fabian Keil [Sat, 13 Nov 2010 20:15:41 +0000 (20:15 +0000)]
Mention that Privoxy would time the hanging connections out, too.

13 years agoUpdate for 3.0.17 release
Fabian Keil [Sat, 13 Nov 2010 14:54:32 +0000 (14:54 +0000)]
Update for 3.0.17 release

13 years agoAdd a line break.
Fabian Keil [Sat, 13 Nov 2010 14:54:11 +0000 (14:54 +0000)]
Add a line break.

13 years agoRebuild man page for 3.0.17 stable
Fabian Keil [Sat, 13 Nov 2010 14:46:01 +0000 (14:46 +0000)]
Rebuild man page for 3.0.17 stable

13 years agoThe two bugs mentioned did actually cause connections to hang, so don't weasel around...
Fabian Keil [Sat, 13 Nov 2010 13:23:12 +0000 (13:23 +0000)]
The two bugs mentioned did actually cause connections to hang, so don't weasel around it with "appear to".

While at it, split the summary into three paragraphs.

13 years agoRegenerate. Once more, with feeling.
Fabian Keil [Sat, 13 Nov 2010 13:12:30 +0000 (13:12 +0000)]
Regenerate. Once more, with feeling.

13 years agoSplit two sentences
Fabian Keil [Sat, 13 Nov 2010 13:04:56 +0000 (13:04 +0000)]
Split two sentences

13 years agoChange wording a bit.
Fabian Keil [Sat, 13 Nov 2010 13:04:39 +0000 (13:04 +0000)]
Change wording a bit.

13 years agoMinor fixes.
Fabian Keil [Sat, 13 Nov 2010 13:04:24 +0000 (13:04 +0000)]
Minor fixes.

13 years agoRebuild with recent changes
Fabian Keil [Sat, 13 Nov 2010 12:52:12 +0000 (12:52 +0000)]
Rebuild with recent changes

13 years agoRebuild for 3.0.17
Fabian Keil [Sat, 13 Nov 2010 12:49:43 +0000 (12:49 +0000)]
Rebuild for 3.0.17

13 years agoRebuild with recent grammar fixes in the ACL section
Fabian Keil [Sat, 13 Nov 2010 12:48:18 +0000 (12:48 +0000)]
Rebuild with recent grammar fixes in the ACL section

13 years agoFix white-space in a log message in remove_chunked_transfer_coding().
Fabian Keil [Sat, 13 Nov 2010 11:09:54 +0000 (11:09 +0000)]
Fix white-space in a log message in remove_chunked_transfer_coding().

While at it, add a note that the message doesn't seem to
be entirely correct and should be improved later on.

13 years agoSplit a sentence in two.
Fabian Keil [Sat, 13 Nov 2010 10:09:39 +0000 (10:09 +0000)]
Split a sentence in two.