From: Fabian Keil <fk@fabiankeil.de>
Date: Mon, 29 May 2017 10:13:36 +0000 (+0000)
Subject: cgi_show_client_tags(): Fix a harmless 'dead store' warning
X-Git-Tag: v_3_0_27~145
X-Git-Url: http://www.privoxy.org/gitweb/junkmail.html?a=commitdiff_plain;h=d5518845fc94b0a0c65d8d5b662c672290463f0e;p=privoxy.git

cgi_show_client_tags(): Fix a harmless 'dead store' warning
---

diff --git a/cgisimple.c b/cgisimple.c
index 638d787f..562eeb63 100644
--- a/cgisimple.c
+++ b/cgisimple.c
@@ -1,4 +1,4 @@
-const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.148 2017/03/08 13:13:18 fabiankeil Exp $";
+const char cgisimple_rcs[] = "$Id: cgisimple.c,v 1.149 2017/05/04 14:33:17 fabiankeil Exp $";
 /*********************************************************************
  *
  * File        :  $Source: /cvsroot/ijbswa/current/cgisimple.c,v $
@@ -391,12 +391,16 @@ jb_err cgi_show_client_tags(struct client_state *csp,
          if (!err) err = string_append(&client_tag_status, "</td></tr>\n");
          if (err)
          {
-            free_map(exports);
-            return JB_ERR_MEMORY;
+            break;
          }
          this_tag = this_tag->next;
       }
       if (!err) err = string_append(&client_tag_status, "</table>\n");
+      if (err)
+      {
+         free_map(exports);
+         return JB_ERR_MEMORY;
+      }
    }
    refresh_delay = get_next_tag_timeout_for_client(csp->client_address);
    if (refresh_delay != 0)