Fabian Keil [Sat, 8 Oct 2011 17:31:51 +0000 (17:31 +0000)]
Reduce server_last_modified()'s stack size
Fabian Keil [Sat, 8 Oct 2011 17:31:05 +0000 (17:31 +0000)]
Shorten get_http_time() by using strftime()
Fabian Keil [Sat, 8 Oct 2011 17:30:21 +0000 (17:30 +0000)]
In chat(), properly report missing server responses as such instead of calling them empty
Fabian Keil [Sun, 18 Sep 2011 14:43:07 +0000 (14:43 +0000)]
Let load_one_actions_file() properly complain about a missing '{' at the beginning of the file
Simply stating that a line is invalid isn't particularly helpful.
Fabian Keil [Sun, 18 Sep 2011 14:42:43 +0000 (14:42 +0000)]
In forwarded_connect(), fix a log message nobody should ever see
Fabian Keil [Sun, 18 Sep 2011 14:41:03 +0000 (14:41 +0000)]
Rephrase #12 as pipelined client requests aren't completely unsupported
Fabian Keil [Sun, 18 Sep 2011 14:40:43 +0000 (14:40 +0000)]
Add a link to the latest version
Fabian Keil [Sun, 18 Sep 2011 14:40:26 +0000 (14:40 +0000)]
Note that #97 is mostly done
Fabian Keil [Tue, 6 Sep 2011 18:46:17 +0000 (18:46 +0000)]
Fix a log message in socks5_connect(), a failed write operation was logged as failed read operation
Fabian Keil [Tue, 6 Sep 2011 18:45:46 +0000 (18:45 +0000)]
Ditch trailing whitespace
Fabian Keil [Tue, 6 Sep 2011 18:45:28 +0000 (18:45 +0000)]
Fix the dok-tidy target to actually suppress backup file creation
Fabian Keil [Sun, 4 Sep 2011 11:37:05 +0000 (11:37 +0000)]
Constify the known_http_methods pointers in unknown_method()
Fabian Keil [Sun, 4 Sep 2011 11:36:50 +0000 (11:36 +0000)]
Constify the time_formats pointers in parse_header_time()
Fabian Keil [Sun, 4 Sep 2011 11:36:33 +0000 (11:36 +0000)]
Constify the formerly_valid_actions pointers in action_used_to_be_valid()
Fabian Keil [Sun, 4 Sep 2011 11:35:49 +0000 (11:35 +0000)]
Fix spelling in a comment
Fabian Keil [Sun, 4 Sep 2011 11:35:38 +0000 (11:35 +0000)]
In html_code_map[], use a numeric character reference instead of ' which wasn't standardized before XHTML 1.0
Oops.
Fabian Keil [Sun, 4 Sep 2011 11:33:50 +0000 (11:33 +0000)]
In parse_header_time(), zero out gmt before each strptime() just to be sure
Fabian Keil [Sun, 4 Sep 2011 11:33:06 +0000 (11:33 +0000)]
Let parse_header_time() look for two-digit years first
Should work around GNU libc's strptime() reporting negative
years when parsing a two-digit year with %Y.
Reported by Väinö in #
3403560
Fabian Keil [Sun, 4 Sep 2011 11:32:20 +0000 (11:32 +0000)]
In parse_header_time(), add a sanity check for GNU libc's strptime() which apparently occasionally returns negative years.
Reported by Väinö in #
3403560
Fabian Keil [Sun, 4 Sep 2011 11:31:45 +0000 (11:31 +0000)]
Dijkstraize parse_header_time(): two or more, use a for
Fabian Keil [Sun, 4 Sep 2011 11:31:17 +0000 (11:31 +0000)]
Adjust a comment in parse_header_time(). Zeroing out gmt is documented to be required for GNU libc
Fabian Keil [Sun, 4 Sep 2011 11:11:17 +0000 (11:11 +0000)]
Ditch trailing whitespace
Fabian Keil [Sun, 4 Sep 2011 11:09:05 +0000 (11:09 +0000)]
Rename the tidy target to clean-editor-files so it can't be confused with the dok-tidy target
Fabian Keil [Sun, 4 Sep 2011 11:08:38 +0000 (11:08 +0000)]
Remove the obsolete browser support matrix. Minor cosmetics.
Fabian Keil [Wed, 31 Aug 2011 13:38:53 +0000 (13:38 +0000)]
The first result of the shiny-new dok-tidy target.
Fabian Keil [Wed, 31 Aug 2011 13:36:35 +0000 (13:36 +0000)]
Bump copyright.
Fabian Keil [Wed, 31 Aug 2011 13:36:15 +0000 (13:36 +0000)]
Add a dok-tidy target to clean up the messy HTML generated by the other dok targets
Not yet connected to any other target,
but probably should be after some testing.
Fabian Keil [Wed, 31 Aug 2011 13:35:21 +0000 (13:35 +0000)]
Ditch a duplicated dot in a comment
Fabian Keil [Sat, 27 Aug 2011 10:36:45 +0000 (10:36 +0000)]
Change the HTTP version in the snipplets to 1.1
The snipplets are compliant, so there's no reason not to.
Fabian Keil [Fri, 26 Aug 2011 16:15:11 +0000 (16:15 +0000)]
Rebuild with updated copyright
Fabian Keil [Fri, 26 Aug 2011 16:14:24 +0000 (16:14 +0000)]
Rebuild with updated copyright and minor changes
Fabian Keil [Fri, 26 Aug 2011 16:13:40 +0000 (16:13 +0000)]
Rebuild after ditching GNUisms in GNUMakefile.in
Fabian Keil [Fri, 26 Aug 2011 16:12:34 +0000 (16:12 +0000)]
Deduplicate a line in the dok-release target
Fabian Keil [Fri, 26 Aug 2011 16:12:14 +0000 (16:12 +0000)]
Add #97: Add support for Tor's 'optimistic data' socks extension.
Fabian Keil [Fri, 26 Aug 2011 16:11:59 +0000 (16:11 +0000)]
Once more, with feeling: GNUisms be gone
This time the dok target has actually been tested on
a GNU/Linux system using GNU make.
Fabian Keil [Mon, 22 Aug 2011 18:58:29 +0000 (18:58 +0000)]
When sending out the "no-server-data" response, do not log two LOG_LEVEL_CLF messages
send_crunch_response() already takes care of emitting the
message, so there's no need for chat() to emit another one.
Noticed while looking into #
3394462 reported by Andy.
Fabian Keil [Thu, 18 Aug 2011 11:45:02 +0000 (11:45 +0000)]
Don't use unspecified MSN sites as examples for User-Agent-based descrimination
Without knowing the URLs, nobody can easily verify it and it could
be mistaken as FUD. I also assume that it's no longer an issue anyway.
Fabian Keil [Thu, 18 Aug 2011 11:42:50 +0000 (11:42 +0000)]
Bump some more documentation copyright ranges.
Fabian Keil [Thu, 18 Aug 2011 11:41:18 +0000 (11:41 +0000)]
Also highlight the compression level, now that it is logged, too
Fabian Keil [Wed, 17 Aug 2011 10:41:21 +0000 (10:41 +0000)]
Rebuild README
Fabian Keil [Wed, 17 Aug 2011 10:41:03 +0000 (10:41 +0000)]
Index updates.
Fabian Keil [Wed, 17 Aug 2011 10:40:07 +0000 (10:40 +0000)]
Update the entities.
This commit is chronological out of order.
Fabian Keil [Wed, 17 Aug 2011 10:37:48 +0000 (10:37 +0000)]
Rebuild user-manual, developer-manual and faq.
Looks like the code status UNRELEASED isn't properly dealt with everywhere,
but as this build is not going to get released, I think we can live with
it for now.
Also ampersands in URLs weren't properly escaped, but hopefully
none of the broken links slipped into this commit. This needs to
be addressed before the next release anyway.
Fabian Keil [Wed, 17 Aug 2011 10:32:44 +0000 (10:32 +0000)]
Formattting fixes missed in the previous commit and forgotten to squash
Fabian Keil [Wed, 17 Aug 2011 10:31:40 +0000 (10:31 +0000)]
Rebuild config with the recently added compression directives
Fabian Keil [Wed, 17 Aug 2011 10:30:36 +0000 (10:30 +0000)]
Bumpy copyright year
Fabian Keil [Wed, 17 Aug 2011 10:30:11 +0000 (10:30 +0000)]
Revert the previous commit for now.
Turns out that it broke a the dok targets. Ooops.
Fabian Keil [Wed, 17 Aug 2011 10:26:47 +0000 (10:26 +0000)]
In compress_buffer(), let zlib figure out the proper length for the new buffer
Simply adding 30 bytes is somewhat "suboptimal".
Fabian Keil [Wed, 17 Aug 2011 10:25:43 +0000 (10:25 +0000)]
Fix a compiler warning on GNU/Linux i386
Fabian Keil [Wed, 17 Aug 2011 10:24:55 +0000 (10:24 +0000)]
When loading action sections, verify that the referenced filters exist
Currently missing filters only result in an error message,
but eventually the severity should be upgraded to fatal.
Fabian Keil [Wed, 17 Aug 2011 10:23:42 +0000 (10:23 +0000)]
Add #96: Enabled filters should be easier to look up
Fabian Keil [Wed, 17 Aug 2011 10:23:23 +0000 (10:23 +0000)]
Get the language for #42 right.
While at it, remove the bible reference as it arrived a while ago.
Fabian Keil [Tue, 2 Aug 2011 18:21:21 +0000 (18:21 +0000)]
Fabian Keil [Sat, 30 Jul 2011 15:22:39 +0000 (15:22 +0000)]
Add tests for missing socks4 and socks4a forwarders
The code paths are different than for socks5 and the recent
memory leak in socks5_connect() was only detected due to the
already existing test.
Currently no such leaks exist in socks4_connect() but I may
add some in the future and would prefer to know about it.
Fabian Keil [Sat, 30 Jul 2011 15:17:35 +0000 (15:17 +0000)]
Deduplicate the INADDR_NONE definition for Solaris by moving it to jbsockets.h
While at it, add a comment about whether or not the workaround is still needed.
Fabian Keil [Sat, 30 Jul 2011 15:15:25 +0000 (15:15 +0000)]
In block_url(), ditch the obsolete workaround for ancient Netscape versions that supposedly couldn't properly deal with status code 403.
Fabian Keil [Sat, 30 Jul 2011 15:13:32 +0000 (15:13 +0000)]
White-space fixes for add_loader() and run_loader()
Fabian Keil [Sat, 30 Jul 2011 15:12:55 +0000 (15:12 +0000)]
Remove a useless NULL pointer check in load_trustfile()
Fabian Keil [Sat, 30 Jul 2011 15:12:42 +0000 (15:12 +0000)]
Remove two useless NULL pointer checks in load_one_re_filterfile().
csp has already been dereferenced earlier and there's
no reason why it should be NULL anyway.
Fabian Keil [Sat, 30 Jul 2011 15:12:02 +0000 (15:12 +0000)]
Set socket_error to errno if connecting fails in rfc2553_connect_to()
Previously rejected direct connections could be incorrectly reported as DNS issues.
Fabian Keil [Sat, 30 Jul 2011 15:05:49 +0000 (15:05 +0000)]
Slightly restructure the error handling in socks5_connect().
No (intended) change of behaviour.
Fabian Keil [Sat, 30 Jul 2011 15:05:23 +0000 (15:05 +0000)]
Add the filter-file loaders before the action-file loaders
This way all filters are loaded by the time the action files
are parsed and filter{} actions specifying non-existent filters
can be detected and rejected (with code not yet committed).
Fabian Keil [Sat, 30 Jul 2011 15:02:57 +0000 (15:02 +0000)]
Disable banners-by-size filters for '.thinkgeek.com/'
The filter only seems to catch pictures of the inventory.
Fabian Keil [Sat, 30 Jul 2011 15:00:20 +0000 (15:00 +0000)]
Block requests for 'go.idmnet.bbelements.com/please/showit/'
Reported by kacperdominik in #
3372959.
Fabian Keil [Tue, 19 Jul 2011 11:01:14 +0000 (11:01 +0000)]
Add #95: Support a non-standard client header in CONNECT requests that contains the URL of the requested ressource
Fabian Keil [Tue, 19 Jul 2011 11:00:38 +0000 (11:00 +0000)]
Remove #71 as it has been implemented a few days ago
Fabian Keil [Tue, 19 Jul 2011 11:00:20 +0000 (11:00 +0000)]
Minor style fix for load_config()
Fabian Keil [Sun, 17 Jul 2011 13:52:11 +0000 (13:52 +0000)]
Make sure --privoxy-address works with IPv6 addresses containing brackets, too
Fabian Keil [Sun, 17 Jul 2011 13:38:05 +0000 (13:38 +0000)]
Minor style fixes for bind_port_helper()
Fabian Keil [Sun, 17 Jul 2011 13:37:32 +0000 (13:37 +0000)]
Reduce code duplication in bind_port_helper()
Fabian Keil [Sun, 17 Jul 2011 13:37:14 +0000 (13:37 +0000)]
Minor style fix for unload_configfile()
Fabian Keil [Sun, 17 Jul 2011 13:36:48 +0000 (13:36 +0000)]
Add a comment about possibly questionable behaviour in accept_connection()
Fabian Keil [Sun, 17 Jul 2011 13:36:27 +0000 (13:36 +0000)]
Style and comment fixes for accept_connection()
Fabian Keil [Sun, 17 Jul 2011 13:36:06 +0000 (13:36 +0000)]
Restructure bind_ports_helper() a bit
Setting config->need_bind isn't necessary.
Fabian Keil [Sun, 17 Jul 2011 13:35:32 +0000 (13:35 +0000)]
Do not claim to listen on a socket until we actually do.
Patch submitted by Petr Písař in #
3354485
Fabian Keil [Sun, 17 Jul 2011 13:34:36 +0000 (13:34 +0000)]
Allow to bind to multiple separate addresses.
Patch set submitted by Petr Písař in #
3354485.
Fabian Keil [Sun, 17 Jul 2011 13:31:35 +0000 (13:31 +0000)]
Fix a memory leak if the socks5 server is unreachable.
I introduced the leak after the last release so this
fix is irrelevant as far as the ChangeLog is concerned.
Fabian Keil [Sun, 17 Jul 2011 13:31:02 +0000 (13:31 +0000)]
Minor style fix for listen_loop().
Fabian Keil [Sun, 17 Jul 2011 13:30:43 +0000 (13:30 +0000)]
Remove #13 which is already implemented.
Fabian Keil [Sun, 17 Jul 2011 13:30:24 +0000 (13:30 +0000)]
Also log the client socket when dropping a connection.
Fabian Keil [Fri, 8 Jul 2011 13:31:40 +0000 (13:31 +0000)]
Document compression-level
Fabian Keil [Fri, 8 Jul 2011 13:31:17 +0000 (13:31 +0000)]
Document enable-compression
Fabian Keil [Fri, 8 Jul 2011 13:30:59 +0000 (13:30 +0000)]
Add a 'to' that was missing in the FEATURE_COMPRESSION description
Fabian Keil [Fri, 8 Jul 2011 13:30:08 +0000 (13:30 +0000)]
Add an enable-compression directive and disable compression by default
Fabian Keil [Fri, 8 Jul 2011 13:29:39 +0000 (13:29 +0000)]
parse_toggle_state() only returns 0 or 1, so check for 1 directly.
Fabian Keil [Fri, 8 Jul 2011 13:29:22 +0000 (13:29 +0000)]
Also let parse_toggle_state() reject values like '1[insert garbage here]'
Fabian Keil [Fri, 8 Jul 2011 13:29:06 +0000 (13:29 +0000)]
Add a dedicated function to parse the values of toggles
Reduces duplicated code in load_config() and provides
better error handling. Invalid or missing toggle values
are now a fatal error instead of being silently ignored.
Fabian Keil [Fri, 8 Jul 2011 13:28:11 +0000 (13:28 +0000)]
If compressing the buffer failed, include buffer size and compression level in the error message
Fabian Keil [Fri, 8 Jul 2011 13:27:56 +0000 (13:27 +0000)]
In compress_buffer(), add some room for the zlib overhead
If the entropy is high enough, the data may not be compressable,
or at least not compressable enough to make room for the header.
If the compression level is 0, the "compressed" is guaranteed
to take more room than the "uncompressed" data.
Fabian Keil [Fri, 8 Jul 2011 13:27:31 +0000 (13:27 +0000)]
Add the config directive compression-level
There isn't a single best compression level for
all situations, so hard-coding one makes no sense.
Fabian Keil [Mon, 4 Jul 2011 17:48:11 +0000 (17:48 +0000)]
#94: Add a config directive to let Privoxy prefer either IPv4 (or IPv6) addresses
Fabian Keil [Mon, 4 Jul 2011 17:47:50 +0000 (17:47 +0000)]
#93: Add a config directive to let Privoxy explicitly request either IPv4 (or IPv6) addresses
Fabian Keil [Mon, 4 Jul 2011 17:47:29 +0000 (17:47 +0000)]
In bind_port(), stop hinting AI_ADDRCONFIG to getaddrinfo()
It's not strictly needed there and causes GNU libc to fail to
return loopback addresses if no non-loopback IP address is
configured on the system. Apparently this is the result of a
somewhat strict but valid interpretation of RFC 3493 and
considered a feature. Sad but true.
This is mainly an issue if the system is using DHCP and Privoxy
is started before the network is completely configured.
Reported by Raphael Marichez in #
3349356.
Additional insight from Petr Pisar.
Fabian Keil [Sun, 3 Jul 2011 17:55:23 +0000 (17:55 +0000)]
Move LOWER_LENGTH_LIMIT_FOR_COMPRESSION into cgi.[ch] where it belongs
While at it, turn it into a proper variable so it can be changed from the debugger.
Fabian Keil [Sun, 3 Jul 2011 17:54:29 +0000 (17:54 +0000)]
Fix spelling of LOWER_LENGTH_LIMIT_FOR_COMPRESSION
Fabian Keil [Sun, 3 Jul 2011 17:53:00 +0000 (17:53 +0000)]
Fix the FEATURE_ZLIB description. It's mainly used for decompression.
Fabian Keil [Wed, 29 Jun 2011 20:31:05 +0000 (20:31 +0000)]
Unbreak execute_dumb_fetch_test().
Apparently 1.73 wasn't regression-tested. How ironic.
Fabian Keil [Wed, 29 Jun 2011 20:30:18 +0000 (20:30 +0000)]
Remove a stray exit(0)
Fabian Keil [Wed, 29 Jun 2011 20:29:58 +0000 (20:29 +0000)]
Cosmetics for generate_creation_time()
Fabian Keil [Wed, 29 Jun 2011 20:29:29 +0000 (20:29 +0000)]
Remove a couple of unnecessary variables in generate_creation_time()